Andrew Arnott

@BoggyS We're actively developing a proper roslyn source generator to replace mpc, in the develop branch. Would you like to give it a try?

We don't have any active contributors who are familiar with Unity at the moment. We'd welcome a PR if you can propose a fix.

You should remove UnityShims from your unity project. Unity already defines these types. The shims are needed for projects that are _not_ compiled within unity.

> I still have to convert my vector3s to and from strings because messagepack couldn’t successfully serialize vector3s. Can you file a separate issue for that? Maybe you can share...

Analyzers aren't incremental though, are they? Our generator has to scan all types to the compilation, remember the interesting ones, then figure out a bunch of stuff for each interesting...

Thanks. I'll revise our code then. FWIW, removing the diagnostic reporting from the generator will not make the generator faster. It has to do all the analysis anyway. Presumably calling...

> if it's a generator that in most user scenarios won't produce output then keeping the diagnostics separate would be helpful. Considering that analyzers don't slow down compilers like generators...

Removing the ability for Source generators to report Diagnostics would be incredibly expensive for the Cswin32 Source generator. Many of its Diagnostics it doesn't know until it's very deeply in...

Cswin32 is not yet an incremental SG. When we get to that, _maybe_ my analysis will change. But I doubt it.

I was just looking at [the changes](https://github.com/conradreuter/cancellationtoken/compare/v2.2.0...v2.3.0-rc1) and have a suggestion before we release. Can we add a test (and product change if required) that shows [`canBeCanceled`](https://github.com/conradreuter/cancellationtoken/blob/9903a65c1953bc8f843eaf9d2aaab80efef763e6/src/CancellationToken.ts#L101) changes from `true`...