A5rocks
A5rocks
Alright, this is now running the whole test suite (rather than the part that doesn't require the test requirements).
Interesting, I don't remember the KI changes in the alpha! Maybe worth bisecting to figure out what exactly changed?
I bisected and KI seems to be failing due to PEP 667 (specifically https://github.com/python/cpython/pull/115153). Which kind of makes sense because we stuff KI protection metadata in weird function places, but...
OK, so KI is cause this no longer works: Before: ```pycon >>> import sys >>> def g(): ... print(sys._getframe(1).f_locals) ... >>> def f(): ... locals()["name"] = True ... g() ......
> The downside to this is it being a silent breaking change, and if a library starts relying on it they will have differing behavior depending on what trio version...
> I guess we could make a deprecation-only release and then un-deprecate it when the semantics change, but I think it's less disruptive overall to just switch to the new...
Yeah ok I agree that it's fine to do this without deprecation. It's not that big of a behavior change (your code runs for just a bit longer) and deprecation...
As a quick fix you can probably `import trio` before monkey patching. This will cache trio with un-patched system things. There has to be a way to fix this that...
Sorry, I mean `import trio` before running `eventlet.monkey_patch()`.
Ok I thought about this some more and this is totally just an eventlet bug. They claim `GreenSocket` is "100% api compatible with `socket.socket`": https://github.com/eventlet/eventlet/blob/8bac9b2bb5ba02d42305446327a117ff51af177b/eventlet/greenio/base.py#L119-L122