aria-query icon indicating copy to clipboard operation
aria-query copied to clipboard

run tests on built test files, test on all supported nodes

Open ljharb opened this issue 1 year ago • 7 comments

This is effectively the same PR as https://github.com/A11yance/axobject-query/pull/356.

ljharb avatar Jul 15 '24 19:07 ljharb

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jul 15 '24 19:07 codesandbox-ci[bot]

This is a Trojan horse pull request. The PR title clearly states that the purpose is to "test built code". In reality, the PR:

  • Sneaks in support for Node 0.4 (I was only able to track down an intention to support Node 6: https://github.com/A11yance/aria-query/pull/162#discussion_r631745298)
  • Replaces fundamental GitHub Actions with ones you control
  • Changes the testing framework to one you control
  • Adds a bunch of new dev dependencies that you control

If you're making changes like this, at least be honest about it. There's nothing to be ashamed of, or is there?

wojtekmaj avatar Jul 16 '24 06:07 wojtekmaj

To be fair, the actions are pinned to a commit. There isn't a risk of malicious code being added there. The deps are more dsngerous though, but there is always some trust in maintainers involved.

AaronDewes avatar Jul 16 '24 08:07 AaronDewes

LGTM

yamiteru avatar Jul 16 '24 10:07 yamiteru

I want to remind you that the previous Trojan pull request was accepted in the neighboring repository https://github.com/A11yance/axobject-query/pull/354

The more you allow someone, the more brazen they become

HawkeyePierce89 avatar Jul 16 '24 13:07 HawkeyePierce89

Doesn't look good to me.

nitelite avatar Jul 16 '24 14:07 nitelite

These are all dev deps, and as such, it doesn’t make sense for anyone but maintainers to have an opinion on them.

@wojtekmaj there’s nothing dishonest here, and accusing me of doing something “sneaky” is an absurd accusation.

ljharb avatar Jul 16 '24 14:07 ljharb