aria-query
aria-query copied to clipboard
feat: Add graphics-* roles
Closes https://github.com/A11yance/aria-query/issues/181
Data is based on WAI-ARIA Graphics Module 1.0 which was parsed by https://gist.github.com/eps1lon/586e9a003c4d1cf3b74a6cd943edc46d.
Pull Request Test Coverage Report for Build 2008123959
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 98.162%
Totals | |
---|---|
Change from base Build 1787050641: | 0.0% |
Covered Lines: | 228 |
Relevant Lines: | 228 |
💛 - Coveralls
@eps1lon looks great! Let's get this in.
@jessebeach is there any chance that ariaGraphicsRoles
isn't being imported into rolesMap
, which is why my tests for https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/756#issuecomment-1292760714 are failing?
@ljharb yes, you are correct. The Graphics roles were created, but there is one missing integration point to get them surfaces: https://github.com/A11yance/aria-query/blob/main/src/rolesMap.js#L10
I can get a patch release of aria-query out later today to plug this gap.
Thank you!
@ljharb try pulling in [email protected]
Unfortunately that doesn't seem to do it - was the build process not ran, perhaps?
Huh, the build is run as part of publish. I'll need to set up this PR locally and test end to end to figure out what's going on.