aria-query icon indicating copy to clipboard operation
aria-query copied to clipboard

feat: Add graphics-* roles

Open eps1lon opened this issue 2 years ago • 1 comments

Closes https://github.com/A11yance/aria-query/issues/181

Data is based on WAI-ARIA Graphics Module 1.0 which was parsed by https://gist.github.com/eps1lon/586e9a003c4d1cf3b74a6cd943edc46d.

eps1lon avatar Mar 19 '22 08:03 eps1lon

Pull Request Test Coverage Report for Build 2008123959

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.162%

Totals Coverage Status
Change from base Build 1787050641: 0.0%
Covered Lines: 228
Relevant Lines: 228

💛 - Coveralls

coveralls avatar Mar 19 '22 08:03 coveralls

@eps1lon looks great! Let's get this in.

jessebeach avatar Aug 25 '22 13:08 jessebeach

@jessebeach is there any chance that ariaGraphicsRoles isn't being imported into rolesMap, which is why my tests for https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/756#issuecomment-1292760714 are failing?

ljharb avatar Oct 26 '22 23:10 ljharb

@ljharb yes, you are correct. The Graphics roles were created, but there is one missing integration point to get them surfaces: https://github.com/A11yance/aria-query/blob/main/src/rolesMap.js#L10

I can get a patch release of aria-query out later today to plug this gap.

jessebeach avatar Oct 27 '22 15:10 jessebeach

Thank you!

ljharb avatar Oct 27 '22 15:10 ljharb

@ljharb try pulling in [email protected]

jessebeach avatar Oct 28 '22 05:10 jessebeach

Unfortunately that doesn't seem to do it - was the build process not ran, perhaps?

ljharb avatar Oct 28 '22 05:10 ljharb

Huh, the build is run as part of publish. I'll need to set up this PR locally and test end to end to figure out what's going on.

jessebeach avatar Oct 28 '22 06:10 jessebeach