CSS-IN-JS-Benchmarks icon indicating copy to clipboard operation
CSS-IN-JS-Benchmarks copied to clipboard

Update to styled-components v4

Open mxstbr opened this issue 6 years ago • 3 comments

mxstbr avatar Nov 26 '18 10:11 mxstbr

Seems like the benchmarks don't work anymore?

TypeError: Cannot read property 'value' of undefined

/cc @A-gambit

mxstbr avatar Nov 27 '18 11:11 mxstbr

This still fails on this line with the error "cannot read property value of undefined":

https://github.com/A-gambit/CSS-IN-JS-Benchmarks/blob/63e1c5228c309086f936409b8979b288f7b7e22e/packages/tests/index.js#L97

If you console.log(currentRes.audits['user-timings']) it shows this:

{ score: null,
  displayValue: '',
  rawValue: null,
  error: true,
  debugString: 'Audit error: Cannot read property \'args\' of undefined',
  optimalValue: undefined,
  extendedInfo: undefined,
  informative: true,
  name: 'user-timings',
  category: 'Performance',
  description: 'User Timing marks and measures',
  helpText: 'Consider instrumenting your app with the User Timing API to create custom, real-world measurements of key user experiences. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/user-timing).' }

Seems like the important bit is Audit error: Cannot read property \'args\' of undefined, but I'm not sure how to further debug this...

mxstbr avatar Nov 27 '18 16:11 mxstbr

@mxstbr Hey mate, did you ever find out why this was broken? Was it something to do with changes to Chrome's user timings?

We're trying to get it back up and running at @modulz, but have run into this problem.

loklaan avatar Mar 28 '19 00:03 loklaan