serverless-dynamodb-local icon indicating copy to clipboard operation
serverless-dynamodb-local copied to clipboard

Published 20 hours ago • verified publisher icon 99x

Fixed hasAdditionalStacksPlugin check if using modules in plugins sec…

Open sampsasaarela opened this issue 5 years ago • 4 comments

Fixes _.get(...).includes is not a function error if serverless.yml looks like this:

plugins:
  localPath: './plugins'
  modules:
    - my-custom-plugin
    - serverless-domain-manager
    - serverless-dynamodb-local
    - serverless-offline

sampsasaarela avatar Mar 24 '19 14:03 sampsasaarela

This is breaking me as well... it appears that this.service.plugins is not an array in the latest version of serverless. Which breaks the check

designfrontier avatar Apr 29 '19 21:04 designfrontier

I have fixed this by using pluginManager, see https://github.com/99xt/serverless-dynamodb-local/pull/222

vkartaviy avatar May 07 '19 14:05 vkartaviy

Thanks @sampsasaarela for the PR. There is another PR #222 for the same purpose sent later on. Will you be able to check whether there is anything we could get from it? I'm approving this, if there are any changes, please incorporate. Waiting for another review before merging.

I think both will do the job, but my version is not dependent parsePluginsObject, the only dependency is lodash as before and should be fully backward compatible.

sampsasaarela avatar May 20 '19 05:05 sampsasaarela

Can this be revisited? Still unable to use enhanced plugin setup. Thanks.

cyberwombat avatar Sep 05 '19 03:09 cyberwombat