dynamodb-migrations icon indicating copy to clipboard operation
dynamodb-migrations copied to clipboard

Simple log message when table exists

Open ghost opened this issue 8 years ago • 0 comments

Right now if table creation fails the error is simply logged out as is, the whole stack. It is ugly. At least for the scenario where table already exist we can simply log the error message.

Below is how it currently looks;

{ ResourceInUseException: Table already exists: dev_Teams
    at Request.extractError (********************************************************************/aws-sdk/lib/protocol/json.js:48:27)
    at Request.callListeners (********************************************************************/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (********************************************************************/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (********************************************************************/aws-sdk/lib/request.js:683:14)
    at Request.transition (********************************************************************/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (********************************************************************/aws-sdk/lib/state_machine.js:14:12)
    at ********************************************************************/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (********************************************************************/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (********************************************************************/aws-sdk/lib/request.js:685:12)
    at Request.callListeners ********************************************************************/aws-sdk/lib/sequential_executor.js:115:18)
    at Request.emit (********************************************************************/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (********************************************************************/aws-sdk/lib/request.js:683:14)
    at Request.transition (********************************************************************/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (********************************************************************/aws-sdk/lib/state_machine.js:14:12)
    at ********************************************************************/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (********************************************************************/aws-sdk/lib/request.js:38:9)
  message: 'Table already exists: dev_Teams',
  code: 'ResourceInUseException',
  time: 2017-08-17T17:21:40.366Z,
  requestId: 'GSMFC0C45TD7CAORUPQP1MD5Q3VV4KQNSO5AEMVJF66Q9ASUAAJG',
  statusCode: 400,
  retryable: false,
  retryDelay: 41.210013426674294 }
{ ResourceInUseException: Table already exists: dev_Users
    at Request.extractError (********************************************************************/aws-sdk/lib/protocol/json.js:48:27)
    at Request.callListeners (********************************************************************/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (********************************************************************/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (********************************************************************/aws-sdk/lib/request.js:683:14)
    at Request.transition (********************************************************************/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo ********************************************************************/aws-sdk/lib/state_machine.js:14:12)
    at ********************************************************************/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (********************************************************************/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (********************************************************************/aws-sdk/lib/request.js:685:12)
    at Request.callListeners (********************************************************************/aws-sdk/lib/sequential_executor.js:115:18)
    at Request.emit (********************************************************************/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (********************************************************************/aws-sdk/lib/request.js:683:14)
    at Request.transition (********************************************************************/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (********************************************************************/aws-sdk/lib/state_machine.js:14:12)
    at ********************************************************************/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (********************************************************************/aws-sdk/lib/request.js:38:9)
  message: 'Table already exists: dev_Users',
  code: 'ResourceInUseException',
  time: 2017-08-17T17:21:40.382Z,
  requestId: 'T7D17SMH6KQPFU50GP06GSP2QBVV4KQNSO5AEMVJF66Q9ASUAAJG',
  statusCode: 400,
  retryable: false,
  retryDelay: 35.89444793078186 }

How it looks with this change applies;

Table already exists: dev_Teams
Table already exists: dev_Users

I think other errors should be thrown instead of being ignored but that could be done in another commit.

ghost avatar Aug 17 '17 17:08 ghost