http-signatures-ruby
http-signatures-ruby copied to clipboard
support for ruby 2.0
Hi, the gem is using required keywords arguments which is a feature introduced in 2.1. Would you consider merging a PR that switches to "normal" keywords arguments?
I'm much more open to supporting 2.0 than I was to 1.9.x. What would that look like?
foo(arg:)becomesfoo(arg: nil)- :+1: simple.
- :-1: we lose the assurance that the argument was passed.
foo(arg:)becomesfoo(arg: nil)with argument assertion in the method body.- :+1: can replicate the current behavior.
- :-1: method bodies become verbose, boilerplate.
- :-1: can't distinguish between argument passed as
niland argument not passed. - not bad overall.
foo(arg:)becomesfoo(arg: raise(ArgumentError, :arg))- :+1: can replicate the current behavior.
- :+1: method bodies don't need to change.
- :-1: method declarations become very long with multiple arguments.
- Something else…?