99designs
Add Directives to Resolver Comments
The default resolver template for code generation is altered such that, the directives that are called are listed in the comment area above the resolver function definition. Parameters of the directives are also included in the output.
This PR closes my issue #3762
As this is a very minor (non-functional) feature, I have not included the following items -> I have:
- [ ] Added tests covering the bug / feature (see testing)
- [ ] Updated any relevant documentation (see docs)
coverage: 73.134%. remained the same when pulling 8f1e7013458acf7ba6dacf083c88c9562b17e183 on aurelius-adrian:master into fadac6f93abf5b7516c0d16e815aeafbc8d63c93 on 99designs:master.
@aurelius-adrian This has PR causes a number of CI failures for our fmt-and-generate. This will have a similar effect for anyone who uses this in their own systems, so I think you should add a config option to allow people to opt-in to this new behavior. I think it is valuable, but I think that some people might want to keep their comments more succinct.
@StevenACoffman I will try to look at it to add an option in the config file and resubmit.
@aurelius-adrian Is this something you are still planning on resubmitting?
Yes, although I am currently involved in other projects and will likely only get to it in mid October.