gqlgen icon indicating copy to clipboard operation
gqlgen copied to clipboard

Upgrading `urfave/cli` to v3

Open oxisto opened this issue 1 year ago • 3 comments

This PR upgrades urfave/cli to v3. This has the advantage to get rid of three dependencies, including blackfriday, which is semi-unmaintained and frankly a markdown processor is simply unexpected as a dependency for a gql code-generator.

Unfortunatly, the v3 is still in beta, so you might want to hold actually merging this, once v3 is officially released. At least the changes are prepared then.

oxisto avatar Dec 24 '24 23:12 oxisto

Coverage Status

coverage: 73.913% (+0.05%) from 73.861% when pulling 06303c0f9fead70ca850190dbcaeb2267bd0ba22 on oxisto:master into 663d0131787b50be55007207f13fe4542b8e3609 on 99designs:master.

coveralls avatar Dec 25 '24 00:12 coveralls

Hey, thanks for the heads up and for this work! I converted this to a draft until 3.0.0 releases, and then I'd love it if you can update it and convert it back to ready to review. If you could ping me, I'd appreciate it, as I might not otherwise notice when 3.0.0 is released.

StevenACoffman avatar Dec 25 '24 01:12 StevenACoffman

Hey, thanks for the heads up and for this work! I converted this to a draft until 3.0.0 releases, and then I'd love it if you can update it and convert it back to ready to review. If you could ping me, I'd appreciate it, as I might not otherwise notice when 3.0.0 is released.

Thanks! I am not affiliated with the project, but just using it in another project. There is a meta thread abut the 3.0.0 release, which I subscribed to and will most likely get some information about a release then. See https://github.com/urfave/cli/issues/833

oxisto avatar Dec 25 '24 08:12 oxisto

@oxisto Could you please rebase your MR and update to the latest version of github.com/urfave/cli/v3

UnAfraid avatar Sep 09 '25 21:09 UnAfraid

Closed in favor of #3889 Thanks!

UnAfraid avatar Oct 31 '25 22:10 UnAfraid