gqlgen icon indicating copy to clipboard operation
gqlgen copied to clipboard
verified publisher icon 99designs

feat: move object directive logic to object function

Open WingT opened this issue 1 year ago • 2 comments

Change-Id: I6d1789756f7990666f4a0e01761a94816f0fc996

Describe your PR and link to any relevant issues. #3306 I have:

  • [ ] Added tests covering the bug / feature (see testing)
  • [ ] Updated any relevant documentation (see docs)

WingT avatar Sep 28 '24 06:09 WingT

I appreciate your working on this, but I actually really prefer to move logic out of the template files and back into library functions in standard Go files. Template logic is harder to maintain, as linters and other unit testing is much harder to deal with inside of templates.

I think your intent of making things simpler and more convenient is a good one though.

StevenACoffman avatar Sep 28 '24 12:09 StevenACoffman

Coverage Status

coverage: 58.865% (-0.02%) from 58.882% when pulling 9569785af57c8ca003b94b04a7594666ec0534f3 on WingT:master into 71770557cc920f0230ba176b16890d6fea06d9cc on 99designs:master.

coveralls avatar Sep 28 '24 12:09 coveralls