gqlgen icon indicating copy to clipboard operation
gqlgen copied to clipboard

fix #1237 remove unreachable types from generated code

Open vikstrous opened this issue 3 years ago • 1 comments

Rebased and improved #1238

Left to do:

  • [ ] Tests for various edge cases. Maybe just make a big file full of unreachable types? https://github.com/99designs/gqlgen/pull/1238/files#diff-41df4b43d528566617cd5b0c3ae5adc68f75a5c2d4fe8a5bb3a5ad10ccad9508
  • [ ] Figure out the right way to handle federation (then Entity type)
  • [ ] Look into removing unused directives
  • [ ] Figure out how to report / not report the warning. Maybe use the "verbose" flag for this? Maybe extend the verbose flag to "log level"?

I have:

  • [ ] Added tests covering the bug / feature (see testing)
  • [ ] Updated any relevant documentation (see docs)

vikstrous avatar May 02 '22 01:05 vikstrous

Coverage Status

Coverage increased (+0.3%) to 74.918% when pulling ae8064c1293a4032347807990135cd77cdc06125 on vikstrous:unreachable2 into 33fe0b9b824ec86699059f410505c02659fc6c81 on 99designs:master.

coveralls avatar May 02 '22 01:05 coveralls