aws-vault Validation for URLs

We were recently seeing quite esoteric failures like this:

aws-vault: error: exec: Failed to get credentials for foo: InvalidRequestException:
{
  RespMetadata: {
    StatusCode: 400,
    RequestID: "4a328325-4fd6-4710-a3ca-12345671234567"
  },
  Error_: "invalid_request",
  Error_description: "Invalid request"
}

It turned out our dev wiki markdown editor had mangled the example AWS config SSO url like this:

sso_start_url=<https://d-1234567890.awsapps.com/start>

The <> are not right.

Would it be worth having validation for the URL? Actually, is this a question for aws-vault or the aws-cli?

Jan 13 '21 09:01 hlascelles

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Jul 13 '21 00:07 stale[bot]

Still a possible improvement.

Jul 13 '21 07:07 hlascelles

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Apr 16 '22 12:04 stale[bot]

Still nice to have.

Apr 20 '22 18:04 hlascelles

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Nov 02 '22 08:11 stale[bot]

Still nice please.

Dec 06 '22 13:12 hlascelles

Hey @hlascelles if you wish to implement this, feel free to open a PR. As I don't intend to implement at this time I will close for now.

Dec 19 '22 04:12 mtibben