Orion Martin

Results 97 comments of Orion Martin

Useful discussion on "why not use strings for tags?" can be found in #2407.

Discussion in Cirq sync: - particularly nice for e.g. redefining `Optional` values to non-optional type - not allowing redefinition enforces cleaner code, but mostly helps with redefinition in multiple scopes...

Discussed in Cirq sync: - We need to incorporate benchmarks into the PR review workflow (specifically highlighting regressions, not blocking PRs) - General concern around hard-to-detect gradual slowdown of code...

Pretty broken - see also: #5775

@maffoo for comments on same-moment measurements sharing a key. In my opinion: measurements sharing a key but on different qubits should not commute past each other or be allowed in...

Chiming in here: noise models can contain user-defined methods for applying noise, which makes serializing these object complicated at best.

My take on this: 1. The only difference I see between QASM custom gates and subroutines is the return value. `CircuitOperation`s seem reasonable for either case - they don't have...

> 2. On `Circuit Operation` vs `_decompse_`, using circuit operation will require extra qubits to be defined for each `gate` defined in asm ? Extra qubits shouldn't be required for...

In my opinion, the "correct" way to implement post-selection in simulation is with a new gate whose `_act_on_` method simply applies the `|0)(0|` or `|1)(1|` operator without checking it against...