8go

Results 215 comments of 8go

Tested with `jami-cli` on Fedora 40 and peer on Android. Working.

> There also is this conundrum: > Why have you not filtered/error'ed the invalid user_ids but let the process continue? I understand the logging, but why not bubble up Errors...

Does this remove the names that consist only of whitespaces (Space, Tabs, ...)? It should.

in src/main.rs you removed 2 lines L#3738-L3739 didn't you want to remove the 2 lines L#3735-L3736 instead ? Please look at this.

I like it :clap: Consider my comments above. Make any needed changes and submit PR. I am happy to merge !

Hello @jknedlik You are the first to offer help :rocket: :clap: What do you wish to do? - refactor code? - add new features? - fix the --verify emoji-req bug...

Do you want to work with AI, like Copilot or similar to improve the code?

Do you know Fractal? https://gitlab.gnome.org/World/fractal It is written in RUST, a GUI client. Would it be possible to get/copy some ideas/features from there?

Hi @jknedlik In general I agree with a lot of what you said: lots of copy/paste, lots of boiler plate, not "abstracted" into higher level data structures, inconsistencies in naming...

As for the 4 specific code snippets above. There was/is no design decision to have them the way they are. They grew that way. Each example can be improved, e.g....