Make CMake script macOS-compatible
Closes https://github.com/8bitbubsy/ft2-clone/issues/13
- Does it work on both Intel Mac and ARM mac?
- MAXOSX_CORE?
- I only have access to an Intel Mac, and it seems to work fine there. (I'm seeing some problems with the program on it but I don't think they're related to these settings)
- Needed by RtMidi to enable CoreMIDI support, though I don't have any hardware available to test the functionality
- I'm not going to add this if it doesn't compile on ARM Macs, I need someone with an ARM Mac to verify.
- Let me try again. :) MAXOSX_CORE? MACOSX_CORE!
Whoops! :sweat_smile:
I'm not going to add this if it doesn't compile on ARM Macs, I need someone with an ARM Mac to verify.
@OPNA2608 We could try with the nixos builders
I have an M1 Mac Mini we could test on!
I have an M1 Mac Mini we could test on!
And?
I'm not going to add this if it doesn't compile on ARM Macs
@OPNA2608 We could try with the nixos builders
Tested on aarch64-darwin via Nixpkgs CI test infrastructure: https://logs.ofborg.org/?attempt_id=663979be-7320-42cc-8225-1daf801410e7&key=nixos%2Fnixpkgs.250732 , aarch64-darwin_ft2-clone_cmake-patch.log.txt
@8bitbubsy ping! This patch has been working well in our builds https://hydra.nixos.org/job/nixpkgs/trunk/ft2-clone.aarch64-darwin
I fixed CMakeLists.txt in the latest commit. Please let me know if it works @fgaz and @OPNA2608. EDIT: Remember to remove any old patches!
It works, thank you!
https://github.com/NixOS/nixpkgs/pull/259155
It works, thank you!
This is awesome! I've just recently become somewhat obsessed with NixOS!
I'm especially interested in seeing if the builds for aarch64 will work! I'm running NixOS on Nvidia Jetson AGX Orin and would love to include FT2 as an essential in my NixOS configuration!
The aarch64 build works on my PineBook Pro running NixOS FWIW.