ft2-clone icon indicating copy to clipboard operation
ft2-clone copied to clipboard

Make CMake script macOS-compatible

Open OPNA2608 opened this issue 3 years ago • 6 comments

Closes https://github.com/8bitbubsy/ft2-clone/issues/13

OPNA2608 avatar Feb 10 '22 10:02 OPNA2608

  1. Does it work on both Intel Mac and ARM mac?
  2. MAXOSX_CORE?

8bitbubsy avatar Feb 10 '22 10:02 8bitbubsy

  1. I only have access to an Intel Mac, and it seems to work fine there. (I'm seeing some problems with the program on it but I don't think they're related to these settings)
  2. Needed by RtMidi to enable CoreMIDI support, though I don't have any hardware available to test the functionality

OPNA2608 avatar Feb 10 '22 10:02 OPNA2608

  1. I'm not going to add this if it doesn't compile on ARM Macs, I need someone with an ARM Mac to verify.
  2. Let me try again. :) MAXOSX_CORE? MACOSX_CORE!

8bitbubsy avatar Feb 10 '22 10:02 8bitbubsy

Whoops! :sweat_smile:

OPNA2608 avatar Feb 10 '22 10:02 OPNA2608

I'm not going to add this if it doesn't compile on ARM Macs, I need someone with an ARM Mac to verify.

@OPNA2608 We could try with the nixos builders

fgaz avatar Feb 10 '22 14:02 fgaz

I have an M1 Mac Mini we could test on!

ghost avatar Aug 07 '22 15:08 ghost

I have an M1 Mac Mini we could test on!

And?

KAMiKAZOW avatar Aug 22 '23 07:08 KAMiKAZOW

I'm not going to add this if it doesn't compile on ARM Macs

@OPNA2608 We could try with the nixos builders

Tested on aarch64-darwin via Nixpkgs CI test infrastructure: https://logs.ofborg.org/?attempt_id=663979be-7320-42cc-8225-1daf801410e7&key=nixos%2Fnixpkgs.250732 , aarch64-darwin_ft2-clone_cmake-patch.log.txt

OPNA2608 avatar Aug 22 '23 13:08 OPNA2608

@8bitbubsy ping! This patch has been working well in our builds https://hydra.nixos.org/job/nixpkgs/trunk/ft2-clone.aarch64-darwin

fgaz avatar Sep 26 '23 07:09 fgaz

I fixed CMakeLists.txt in the latest commit. Please let me know if it works @fgaz and @OPNA2608. EDIT: Remember to remove any old patches!

8bitbubsy avatar Sep 26 '23 11:09 8bitbubsy

It works, thank you!

https://github.com/NixOS/nixpkgs/pull/259155

fgaz avatar Oct 05 '23 16:10 fgaz

It works, thank you!

NixOS/nixpkgs#259155

This is awesome! I've just recently become somewhat obsessed with NixOS!

I'm especially interested in seeing if the builds for aarch64 will work! I'm running NixOS on Nvidia Jetson AGX Orin and would love to include FT2 as an essential in my NixOS configuration!

JoNilsson avatar Oct 05 '23 18:10 JoNilsson

The aarch64 build works on my PineBook Pro running NixOS FWIW.

OPNA2608 avatar Oct 05 '23 18:10 OPNA2608