Vaibhav Tripathi comments

Repositories
Issues
Comments

Results 35 comments of


                                            Vaibhav Tripathi

fix(storage): expose status and statusCode on StorageError base class

@mandarini

fix(auth): add dispose method to cleanup BroadcastChannel

@mandarini

fix(auth): correct getAuthorizationDetails return type for already consented OAuth responses

> I'd prefer a union type of the 2 possible options. Lets see what @mandarini suggests, will adjust accordingly if needed! 💚🙌

fix(auth): correct getAuthorizationDetails return type for already consented OAuth responses

@mandarini can u have another look on this? also please lmk if any more changes are required! 😁💚

fix(auth): make _notifyAllSubscribers non-blocking to prevent callback deadlocks

hey @mandarini almost forgot about this, was curious if this aswell is being discussed internally (in the recent lock related discussion) ? or should i continue with the suggested approaches?...