acf-svg-icon icon indicating copy to clipboard operation
acf-svg-icon copied to clipboard

Published 20 hours ago • verified publisher icon 7studio

replaced acf_get_dir() with acf_get_url() to suppress notice from ACF

Open pixelspokefitz opened this issue 5 years ago • 2 comments
trafficstars

Hi there, this will resolve issue #6 would you mind publishing this to the WordPress repository?

pixelspokefitz avatar Dec 27 '19 23:12 pixelspokefitz

@pixelspokefitz according to #6 this was deprecated on v5.6.8 so the fix should only be applied for newer versions or at least those that actually include the method. Haven't checked if that's always been around or not though, so your changes may already be correct (pointing it out just in case).

hacknug avatar Jan 23 '20 15:01 hacknug

Hi @pixelspokefitz,

Thank you for your contribution.

@hacknug is right. We need to have a backwards compatibility with the old versions of ACF and it's important to check which function we should used.

Can you update your PR to take into account this please?

7studio avatar Nov 20 '20 15:11 7studio