idealingua-v1 icon indicating copy to clipboard operation
idealingua-v1 copied to clipboard

Lens extension(s)

Open pshirshov opened this issue 7 years ago • 7 comments

  1. We definitely need lense generator for scala
  2. Other languages would be nice as well.

pshirshov avatar Jul 18 '18 10:07 pshirshov

This should be an independent module? Can I take it?

vitaliihonta avatar Feb 04 '19 15:02 vitaliihonta

@vitaliihonta Hi, thank you very much for asking! We welcome all contributions, and especially a major contribution such as a lens module. However, now would be a bad time to take on this task because we're in the middle of rewriting Idealingua's typer, see https://github.com/pshirshov/izumi-r2/issues/305 - to implement this right now you'd have to write field extraction logic ad-hoc for every target language and most of that code would have to be changed after the rewrite.

neko-kai avatar Feb 04 '19 15:02 neko-kai

Hi,

Actually @kaishh is right. It's a bad idea to start working on this now. We should precompute an abstract representation for lenses during typing phase then render it in each of the code generators. At the moment you would have to do it independently for each target language.

You may help us to design and implement our new typer, let us know if interested :)

pshirshov avatar Feb 04 '19 16:02 pshirshov

@pshirshov @kaishh can you suggest some good first issue ?)

vitaliihonta avatar Feb 08 '19 08:02 vitaliihonta

@vitaliihonta Are you open to contributing to other parts of the project besides IDL?

neko-kai avatar Feb 09 '19 12:02 neko-kai

For other projects there are a couple of isolated issues:

neko-kai avatar Feb 09 '19 12:02 neko-kai

@vitaliihonta so, new typer is almost ready. If you really want to take this - you may look at branch feature/typer2 and ask your questions )

pshirshov avatar Mar 15 '19 13:03 pshirshov