active_record-annotate icon indicating copy to clipboard operation
active_record-annotate copied to clipboard

Published 20 hours ago • verified publisher icon 7even

Add Support for Ignoring Models with `config.ignored_models`

Open westonganger opened this issue 6 years ago • 5 comments

Solves #13

westonganger avatar Feb 07 '19 05:02 westonganger

Sorry I didn't mention this earlier but I don't think we need another means of configuration since the gem already has one. Could you please just add the ignored_models option there?

7even avatar Feb 07 '19 20:02 7even

Jeez that sucks. I guess I didn't read the readme well enough because there is no configurator example shown.

westonganger avatar Feb 07 '19 21:02 westonganger

I've added specs however I cannot test ignored_models during annotation as the test suite doesn't seem to support the implemented method for translating the file name to class. Likely you would need to add a full Rails app to the test suite.

westonganger avatar Feb 10 '19 09:02 westonganger

I have some other more important tasks on the go right now. Do you have any interest in picking up this PR and finishing the specs for it?

westonganger avatar Feb 11 '19 19:02 westonganger

@westonganger currently I can't, sorry. Maybe in a few weeks.

7even avatar Feb 12 '19 01:02 7even