SlickGrid icon indicating copy to clipboard operation
SlickGrid copied to clipboard

Collapsing a group leaves one row showing, feature or bug?

Open dedward3 opened this issue 9 years ago • 9 comments

I currently have a nested grouping setup. When I minimize a 2nd level grouping it leaves one data row showing, and when I minimize a top level grouping it levels one of the 2nd level groupings showing. Just curious if this is seen as a feature or bug?

1stlevelcollapse

Note: the data that is visible here actually should be grouped under the 1st grouping, not the second. 2ndlevelcollapse

dedward3 avatar Jul 07 '16 13:07 dedward3

That looks like a bug. I remember something like this was fixed a long time ago. Perhaps we need to revisit it. If it's not clear where the problem is, I think I have a personal branch where it might be fixed.

6pac avatar Jul 07 '16 14:07 6pac

I'll take a look into it and try and figure out where it's deviating. Can you point me in the direction of where aggregation and rendering occur in SlickGrid?

dedward3 avatar Jul 07 '16 19:07 dedward3

That stuff's in slick.dataview.js, the totalling around addTotals() and eventually the tree is flattened into rows for display at flattenGroupedRows()

I've been wondering if the bug is to do with group totals row display. Not sure if I've tested that much with it turned off.

6pac avatar Jul 08 '16 00:07 6pac

would be interested if you can tweak the settings on the example page to reproduce this issue

6pac avatar Jul 08 '16 01:07 6pac

Okay, I'll see if I can reproduce it later today and let you know.

dedward3 avatar Jul 08 '16 13:07 dedward3

i'm away till sun 17th so won't be getting to it real soon :-)

6pac avatar Jul 09 '16 01:07 6pac

any luck?

6pac avatar Jul 21 '16 08:07 6pac

Sorry, I got sidetracked on something else. I'll try and get to it this evening, or tomorrow morning.

dedward3 avatar Jul 27 '16 17:07 dedward3

Can you possibly tweak an example page to reproduce this behaviour?

6pac avatar Aug 19 '16 08:08 6pac

closing since no feedback were provided and a lot had change since then we removed jQueryUI in v3.0 and we also removed jQuery in v4.0 which we just released (see v4.0.0 release)). Feel free to reopen by providing more details if it's still an issue

ghiscoding avatar May 29 '23 15:05 ghiscoding