uniswap-sushiswap-arbitrage-bot icon indicating copy to clipboard operation
uniswap-sushiswap-arbitrage-bot copied to clipboard

Are the parameters to computeProfitMaximizingTrade correct?

Open tthil opened this issue 2 years ago • 5 comments

The call to the smart contract function computeProfitMaximizingTrade takes 4 parameters (sReserve0, sReserve1, uReserve0, uReserve1) The parameter list in the smart contract is defined as
computeProfitMaximizingTrade( uint256 truePriceTokenA, uint256 truePriceTokenB, uint256 reserveA, uint256 reserveB

My question is if sReserve0 and sReserve1 really are truePriceTokenA and truePriceTokenB?

tthil avatar Sep 26 '22 16:09 tthil

Were you able to improve this?

0xNagato avatar Nov 16 '22 17:11 0xNagato

Hi,

No, I moved on. I felt like this repo is dead and more of a test.

//Thomas

On 17 Nov 2022, at 00:53, 0XFEZ @.***> wrote:

Were you able to improve this?

— Reply to this email directly, view it on GitHub https://github.com/6eer/uniswap-sushiswap-arbitrage-bot/issues/24#issuecomment-1317424592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPF26ZPJQJF7BA63BSRBBTWIUNSJANCNFSM6AAAAAAQV6VQJQ. You are receiving this because you authored the thread.

tthil avatar Nov 17 '22 03:11 tthil

Did you have any luck finding any good ones? I'm very stuck

0xNagato avatar Nov 17 '22 03:11 0xNagato

I decided to dig deeper into by myself and build it from scratch as it is more to it than just the interaction with the smart contract.

//Thomas

On 17 Nov 2022, at 10:57, 0XFEZ @.***> wrote:

Did you have any luck finding any good ones? I'm very stuck

— Reply to this email directly, view it on GitHub https://github.com/6eer/uniswap-sushiswap-arbitrage-bot/issues/24#issuecomment-1318030169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPF265NXNDUBFILXCO6KGLWIWUJJANCNFSM6AAAAAAQV6VQJQ. You are receiving this because you authored the thread.

tthil avatar Nov 17 '22 04:11 tthil

Hi Thomas, I do want to build it myself too but i need inspiration to build a more competitive bot joining this late

manzub avatar Nov 12 '23 16:11 manzub