Matt Taylor

Export and use ASAN in mlibc

1

#480 implements UBSAN hooks for internal use. We could do the same for ASAN. This would require some amount of work to manually poison and unpoison any memory we receive...

This causes a crash at https://github.com/managarm/mlibc/blob/51e8c380496cbd065fcd286808908cdb595a3507/options/internal/generic/charcode.cpp#L62. Blocks fish.

For best performance, we should implement ifuncs. These can be used to select between more optimised versions of functions depending on which CPU features are available. This will require some...

termios: Add missing special character defines

1

We are missing a few special character defines like `VDISCARD`. This requires extending the `NCCS` field in `struct termios` which is an ABI break. We should also use enums for...

We ought to loop over the TCBs of all threads and update them whenever we load a new shared library, since it might have thread local variables itself. For this...

The current mlibc ABI for these macros looks like this: ```c #define WEXITSTATUS(x) ((x) & 0x000000FF) #define WIFCONTINUED(x) ((x) & 0x00000100) #define WIFEXITED(x) ((x) & 0x00000200) #define WIFSIGNALED(x) ((x) &...

HistSet::incr and decr are unsound

2

https://github.com/image-rs/imageproc/blob/master/src/filter/median.rs#L248 These functions should be marked as unsafe since incorrect x and y inputs would lead to an out of bounds memory access. As a general note, I see many...

Audit smallvec

2

Over 10k downloads/day and contains a lot of unsafe. Has had a number of vulnerabilities in the past.

README should list time of audit (or version audited)

2

Otherwise 2 years later we have a misleading notice saying 'X is safe' when a new PR added 50 extra unsafe blocks.

Support postgres prepared statements

6

It's possible to use `client.prepare` to get a `Statement` object and execute / query it later. Since `Statement`s need to be used on the same connection that created them, `l337`...