adPEAS icon indicating copy to clipboard operation
adPEAS copied to clipboard

Integration in PEASS-ng

Open carlospolop opened this issue 3 years ago • 3 comments

Hi mate! This tool looks interesting Because of the name and that I was thinking about creating a Winpeas in powershell, let me know if you would be interested in maintaining it the PEASS-ng repository with the rest of the PEASSes (keeping your authority over your tool obviously)

carlospolop avatar Feb 03 '22 19:02 carlospolop

I really appreciate that you want to include adPEAS in PEASS-ng. Feel free to fork it to your repo and I will try to find time to contribute. I guess the process of fixing bugs and implementing new things will speed up with the help of more contributors. Just keep in mind, that I won't have the time to take care of all the issues and pull requests, which indeed will popup if adPEAS is hosted in your amazing PEASS-ng suite. By the way, I really love linPEAS and winPEAS and your idea inspired me to code something similar for Active Directory.

61106960 avatar Feb 04 '22 07:02 61106960

Cool, however, in order for this script to be a new PEASS I need to ask you for some "small" changes/additions that I hope you agree with:

  • Add a PEASS ascii or ansi art (you can copy Winpeas from the .exe so it has colors if you don't want to create a new one)
  • Use the same characters as Winpeas too identify section titles and links with references so https://github.com/carlospolop/PEASS-ng/blob/master/parser/peass-parser.py can create a JSON of the report (soon I will release a way to transform that JSON to HTML)
  • Use at least the red color to color output that is suspicious and/or could lead to privesc somehow. This one is pretty important as that's the signature of the PEAS Suite.

carlospolop avatar Feb 05 '22 13:02 carlospolop

I will implement it as soon I have time and will come back to you. It's likely that it will take some time.....

61106960 avatar Feb 06 '22 11:02 61106960

It took some time but now I've added ANSI color and did some re-work of code. So, if you still like you can give it a try.

61106960 avatar Feb 13 '23 09:02 61106960

@61106960 any news on this integration ?

AkechiShiro avatar May 19 '23 12:05 AkechiShiro

I guess it is up to @carlospolop, if he likes to implement/bundle it.

61106960 avatar May 23 '23 12:05 61106960

Hi @61106960, Have you though how would you like to do this? Would you prefer to move the script to the PEASS-ng repo and add you there as collaborator so you can modify the script. Or would you prefer to maintain it here and set a GH action to send a PR to the PEASS repo everytime you update it?

Also, would you mind adding the winpeass banner to the output of adpeas?

carlospolop avatar May 23 '23 16:05 carlospolop

I will think about a good strategy to have it included in your PEASS-ng suite.

61106960 avatar May 27 '23 10:05 61106960

@61106960 any news on this integration ?

Talha-Kircili avatar Jul 03 '23 10:07 Talha-Kircili

I've thought about it and I'd like to leave it as it is. So no integration in PEASS-ng but I appreciate the request to integrate it.

61106960 avatar Jul 06 '23 11:07 61106960

Thanks @61106960, if someone else wants to work on integrating it, could they ?

AkechiShiro avatar Jul 06 '23 12:07 AkechiShiro

Indeed, it's a free world ;-)

61106960 avatar Jul 06 '23 12:07 61106960