webpack-hot-server-middleware icon indicating copy to clipboard operation
webpack-hot-server-middleware copied to clipboard

Published 20 hours ago • verified publisher icon 60frames

Types: Add support for `createHandler`

Open hedgepigdaniel opened this issue 4 years ago • 2 comments

Previously the returned handler was typed as an express request handler, even if the createHandler option had been used to return something different.

With these changes there is a type parameter for the handler exported by the handler creation function inside the compiler, and for the handler returned by createHandler. They both default to express handlers, so there is no breaking change.

hedgepigdaniel avatar Feb 11 '20 05:02 hedgepigdaniel

Coverage Status

Coverage remained the same at 100.0% when pulling c61cb68511735c8bb4471a7766bb8cb4e0a50d8a on hedgepigdaniel:types/createHandler into ffcf4139155df48d1faf027ae9fd45d37d96953d on 60frames:master.

coveralls avatar Feb 11 '20 05:02 coveralls

Any chance of coming back to this?

hedgepigdaniel avatar Feb 25 '21 06:02 hedgepigdaniel