ios
ios copied to clipboard
5calls
Expatriate Support: Prepend phone number with US Country Code +1
Currently when tapping a phone number from outside of the US, the call will not work because the US Country Code +1 is not present. Appending the +1 should happen automatically if the location of the phone is outside the US. Could also investigate just including the +1 for all calls, or including it as a setting.
@nickoneill is this being done yet? Do you have an issue to link to on the server repo?
I'm not against adding an option in the iOS app, but would be easier to fix globally.
Another thought on this, we might want to not display the "+1-" by default on the call screen, so if we do end up doing this on the server we'll probably strip it out for display only.
We did some prep to add +1 to numbers via the server, it needs to be tested with the existing version of the app before we start rolling it out.
Is there a reason to strip the +1 for display in some cases?
Only that it looks “weird” for most Americans :P
It also might make things more compact on the SE device.
On Jul 22, 2017, at 1:37 PM, nickoneill [email protected] wrote:
We did some prep to add +1 to numbers via the server, it needs to be tested with the existing version of the app before we start rolling it out.
Is there a reason to strip the +1 for display in some cases?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/5calls/ios/issues/161#issuecomment-317202154, or mute the thread https://github.com/notifications/unsubscribe-auth/AADnBFZrJEvz68MrRFizsfUEqHkWECJXks5sQkFygaJpZM4NQUYK.
Hi! Wanted to +1 this (hah).
Happy to contribute a PR if it's helpful, but it sounds like the barrier here is process rather than code needed?
I wonder if it would be weird to keep the display as XXX-XXX-XXXX but have the number dialed include the +1. All numbers from the server don't include the +1 right now, and I'm not sure they should. Is there a situation where we'd have a non-+1 number?
Is this still needed? There are things that can be done around formatting phone numbers with https://github.com/marmelroy/PhoneNumberKit, although that means bringing in another dependency.
