Support Dynamic Type Changes

[subdigital]

Currently the app doesn't respond to dynamic type changes. This is something we should fix to be more accessible.

A probably incomplete list of places that need this work:

• [x] Issue Detail
• [x] Call Scripts
• [x] About screen
• [x] Onboarding screens
• [x] Issue list (front page and more)
• [ ] Impact
• [ ] Reminders
• [ ] Set location

[Abizern]

Related to this - How tied are we to using Roboto rather than the system font? This would be much smaller task if that were the case.

I realise that there may be issues about maintaining a consistent typeface across Web, Android and Mobile. I also realise that it is something of a personal bugbear of mine to use the Android system font on an iOS device.

Of course, this would mean making other related changes to the app and the css files used for serving stored web content. But the app is already a little inconsistent with the Welcome screen using the system font.

So it would make implementing this feature easier, and make the app look more native, at the cost of having to rework parts of the app and, maybe the design.

[nickoneill]

I'm happy to use the default for the platform for most text, particularly if it makes things simpler. The only case I really care about maintaining the font is in the logo which is generally not dynamically rendered anyway. We didn't pick Roboto (and technically it's Roboto Condensed) based on android, it was inherited from the logo usage when we were web only.

[Abizern]

I don't want to mess with the logo, and that's not something that's affected by this.

If a few more people come in on the same side I'll start work on it in a couple of days (unless someone else wants to take it). It's a good step for accessibility.

[subdigital]

+1 on native font

On Oct 10, 2017, at 6:24 PM, Abizer Nasir [email protected] wrote:

I don't want to mess with the logo, and that's not something that's affected by this.

If a few more people come in on the same side I'll start work on it in a couple of days (unless someone else wants to take it). It's a good step for accessibility.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/5calls/ios/issues/144#issuecomment-335636674, or mute the thread https://github.com/notifications/unsubscribe-auth/AADnBK1dH3mhkw0aYzBsV1cLagPocbRXks5sq_y6gaJpZM4Mw2ur.

[iainsmith]

Hey All,

I've started diving into this. As we're supporting iOS 10 we can mostly get away with using

adjustsFontForContentSizeCategory = true // or set in storyboard font = UIFont.preferredFont(forTextStyle: .body) // or set in storyboard

I have opened a WIP PR for this here #245

[nickoneill]

Do your two PRs handle all the cases for dynamic type @iainsmith?

[iainsmith]

Hey @nickoneill, there are a few screens that don’t have any support for dynamic type yet. We could leave this ticket open for a while or open new tickets that are specific to a screen.

[nickoneill]

Sounds great @iainsmith! You don't need to do all the dynamic type work yourself, but can you list the other screens here that need work so I can point folks in that direction?

[nickoneill]

I'm going to put out a release to fix the list stuff later tonight, moving the rest of the items here to 1.6