contract-proxy-kit icon indicating copy to clipboard operation
contract-proxy-kit copied to clipboard

Published 20 hours ago • verified publisher icon 5afe

Implement new factory

Open cag opened this issue 5 years ago • 1 comments

(Just listing everything that this should handle)

  • [x] Resolves #31
  • [x] Resolves #38
  • [x] Resolves #39
  • [x] Resolves #46
  • [x] Resolves #67
  • [x] Resolves #90
  • [x] Resolves #105
  • [x] Related: #102

cag avatar Sep 10 '20 21:09 cag

Ugh, this is still not ready, and generalizing setup straight up made an obvious security vulnerability, which I realized while thinking about the implication of this design, which would in any case require a signature and a transaction authorization on MM (so two user interactions per batch instead of the one that is the case right now). Thought about tx.origin but that opens up a can of phish.

Okay, I'll resolve this by requiring the owner to either be the msg.sender or to have signed the creation params.

Note to self: rename from facade to adapter because that contract now has a more complicated interface and it's only used to ease working with the Safe relay.

cag avatar Dec 29 '20 00:12 cag