mphx
mphx copied to clipboard
Improve codebase
A number of smaller issues have emerged that tend to get private messaged or just noticed in the code.
- [ ] Errors are not handled well - they are done through string responses that do not have a standard and are only useful when shown to the user - not when deciding what to do. Replace with enum?
- [ ] Remote connections that fail freeze until timeout [?]
- [x] Client crashes if sending is attempted while not connected to server.
- [ ] Continuing from the error issue, a debug mode could be good for printing warnings about issues that are unhandled.
- [x] Haxelib is long overdue for an update. The current version barely works.
- [x] Versions between the readme and haxelib are not aligned.
- [x] MessagePack is a required dependency but does not have a serialization class.
- [x] Some files don't make sense, are unused left overs, or are in the wrong place. Things like run.hxml in the top directory have no use.
These shouldn't take long to resolve.
The client should now silently abort if send()
is called while a connection is not properly established. It doesn't output anything to console yet - it will output some sort of warning when proper logging is setup.
Alright sweet thanks for the improvement.
77c6aa2fa5492011b4d
Versions between the readme and haxelib are not aligned.
I considered rolling the haxelib back to 0.0.1, but that could have broken sematic versioning and could cause actual breakages within haxelib. Instead, readme's and everything are pushed forwards to version 0.2.4
. changelog file was added. I swear I'd already made a changelog file but I couldn't see it.
MessagePack removed
This was brought up in an issue and I shut it. I've decided to take the issues advice and kill the dependency. If it is required, JSON can be used, or MsgPack, but so far that hasn't seemed required. It's silly having a dependency if it's not used in code and not yet requested.
File deletion
Unused files (run.hxml) were deleted.