node-red-contrib-alexa-remote2 icon indicating copy to clipboard operation
node-red-contrib-alexa-remote2 copied to clipboard

Published 20 hours ago • verified publisher icon 586837r

Added textCommand

Open mbalduccini opened this issue 4 years ago • 7 comments

Added textCommand -- see https://github.com/thorsten-gehrig/alexa-remote-control. Version bumped to 3.10.5.

mbalduccini avatar Dec 19 '20 21:12 mbalduccini

Hey, thanks for continuing to develop the Node! How about upgrading the alexa-remote dependency to version 3.5.0 (https://github.com/Apollon77/alexa-remote) and using the textCommand function integrated there as all other functions do? Then all commands would be included in the dependency; it would be easier if amazon changes something. Thank you, Achim

ammawel avatar Dec 29 '20 10:12 ammawel

Hi! It would be good, but as far as I can tell none of the other commands from alexa-remote-routine.js is implemented using alexa-remote. Wouldn't switching everything require an almost complete rewrite of alexa-remote-routine.js? Or did I misunderstand your suggestion?

Best, Marcello

mbalduccini avatar Jan 03 '21 14:01 mbalduccini

Hi Marcello! The dependency alexa-remote is used after all. A big problem with contrib-Alexa-remote2 is that the speak-command no longer works at some point - all other commands still work. (node-red-forum, issues on github i.e., or here ) No error message is given until version 3.5.0 of the dependency. Only with the new 3.5.0 there is a null object in case of an error (Alexa says nothing) returned, otherwise "suucess: true" is delivered as result. So the code of the dependency is obviously used. But the next problem is that the node-red module seems to be no longer maintained; the only maintainer 586837r has not been active since July and does not answer questions or error messages. I'm afraid he won't answer your pull-request either ;-) Actually, contrib-Alexa-remote2 is not usable in its current form, especially if Amazon changes something. Unfortunately, there doesn't seem to be an alternative for this modul in node-red either.

Best regards, Achim

ammawel avatar Jan 03 '21 16:01 ammawel

Maybe it’s time to fork this repo. And update https://github.com/Apollon77/alexa-remote

dependency

MattL0 avatar Jan 06 '21 06:01 MattL0

Hi @mbalduccini. I have forked this node (https://github.com/bbindreiter/node-red-contrib-alexa-remote2-applestrudel) and would like to incorporate your PR.

Can you rebase and create a PR in my repo? If not, are you ok with me adding your code (with full attribution of course)?

Thanks

bbindreiter avatar Jun 06 '21 15:06 bbindreiter

Hi @mbalduccini. I have forked this node (https://github.com/bbindreiter/node-red-contrib-alexa-remote2-applestrudel) and would like to incorporate your PR.

Can you rebase and create a PR in my repo? If not, are you ok with me adding your code (with full attribution of course)?

Thanks

If you'd like to point me to the steps needed for rebasing and creating a PR in your repo, I'll be happy to do it. Otherwise, it's also ok with me if you go ahead and add my code.

mbalduccini avatar Jun 07 '21 14:06 mbalduccini

Thanks @mbalduccini. I've added your code changes here: https://github.com/bbindreiter/node-red-contrib-alexa-remote2-applestrudel/commit/ab48b11e3f4e38046a8611e8edd104e5b48bf89d

bbindreiter avatar Jun 07 '21 20:06 bbindreiter