ComfyUI-DareMerge icon indicating copy to clipboard operation
ComfyUI-DareMerge copied to clipboard

Mask stops changing after the second change

Open miasik opened this issue 4 months ago • 0 comments

How to reproduce with the attached workflow: SD15 Dare.json

You need a cartoon and a photo models to easily see the difference. SD15 is better for speed.

Model A — cartoon Model B — photo

Before the first run: Alpha = 0 but threshold=(0, below)

select: below threshold: 0.0 Selected: (0) Excluded: (409600)
select: below threshold: 0.0 Selected: (0) Excluded: (1280)
select: below threshold: 0.0 Selected: (0) Excluded: (1638400)
select: below threshold: 0.0 Selected: (0) Excluded: (1280)
select: below threshold: 0.0 Selected: (0) Excluded: (11520)
...

so everything is excluded and I expect to see the result as a cartoon, because ModelA is cartoon and ModelB is blocked First run — I get a cartoon image, it's expected, so it's OK

Before the second run: threshold=(0, above). Now I expect to get a photo because ModelB is photo and everything is selected

select: above threshold: 0.0 Selected: (409600) Excluded: (0)
select: above threshold: 0.0 Selected: (1280) Excluded: (0)
select: above threshold: 0.0 Selected: (1638400) Excluded: (0)
select: above threshold: 0.0 Selected: (1280) Excluded: (0)
select: above threshold: 0.0 Selected: (11520) Excluded: (0)
...

After the second run I get a photo, it's expected, so its OK

Before the third run: Again, threshold=(0, below) and I expect to get a cartoon image as it was at the first run. After the run started I see animation of working "Magnitude Masker", "Model Merger (Block/DARE)" and the same log as for the firs run but the resulting image is a photo, it's the same as for the 2nd run

In order to make the mask following new settings I need to switch ModelA to anything else, run, switch back and run again. Looks like "Merger" node doesn't get the unpatched model but works with already patched instead.

miasik avatar Sep 29 '24 20:09 miasik