moose icon indicating copy to clipboard operation
moose copied to clipboard

Add proptest for all the parsers & fix bugs

Open LucioFranco opened this issue 1 month ago • 2 comments

[!NOTE] Adds proptest-based tests and regressions across parsers, fixes UTF-8 panic in timeout parsing, and normalizes JSON empty-params equality in the ClickHouse type parser.

  • Testing (proptest):
    • Add proptest infrastructure (proptest.toml) and regression seed files under apps/framework-cli/proptest-regressions/**.
    • Introduce extensive property-based tests in framework/scripts/utils.rs, framework/versions.rs, infrastructure/olap/clickhouse/sql_parser.rs, and .../type_parser.rs (with custom generators).
    • Update Cargo.toml dev-deps: add proptest, proptest-derive.
  • Bug Fixes:
    • framework/scripts/utils.rs: make parse_timeout_to_seconds UTF-8 safe (no panics on multi-byte chars); add regression test.
    • .../type_parser.rs: implement custom PartialEq (and Eq) for ClickHouseTypeNode so JSON(Some([])) equals JSON(None); add regression test and roundtrip properties.
  • Docs:
    • Add PROPTEST_FINDINGS.md documenting discovered issues and fixes.
  • Build:
    • Lockfile updates; unify syn dep versions (via transitive updates).

Written by Cursor Bugbot for commit 4d9d42d05a1c908337dd542203e84249e5b456d3. This will update automatically on new commits. Configure here.

LucioFranco avatar Nov 12 '25 18:11 LucioFranco

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Nov 12, 2025 6:33pm
framework-docs Ready Ready Preview Comment Nov 12, 2025 6:33pm

vercel[bot] avatar Nov 12 '25 18:11 vercel[bot]

Undrafting this so cursor will give me a description

LucioFranco avatar Nov 12 '25 18:11 LucioFranco