react-native-readium icon indicating copy to clipboard operation
react-native-readium copied to clipboard
verified publisher icon 5-stones

feat(ios, android) send epub positions data

Open alecdhansen opened this issue 1 year ago • 3 comments

I found it useful to have access to the epub's positions data for building scrub control components, etc.

Screenshot 2024-11-25 at 12 22 00 PM Screenshot 2024-11-25 at 12 22 48 PM

alecdhansen avatar Nov 25 '24 19:11 alecdhansen

@alecdhansen , thanks for the PRs!

After taking a look at them, I'm now wondering if all the metadata events should be combined into a single one likeonPublicationReady which would contain the ToC, Positions, and Metadata. Since they're all available at the same time I'm not sure if splitting them out into separate events provides much benefit.

Interested in your thoughts.

jspizziri avatar Nov 26 '24 18:11 jspizziri

@jspizziri that makes sense to me. Your call! I could close these two PRs and open another one to combine the 3.

alecdhansen avatar Nov 27 '24 04:11 alecdhansen

@alecdhansen That'd be great, thanks! We'll flag the ToC event as deprecated.

jspizziri avatar Nov 27 '24 11:11 jspizziri