react-native-readium
react-native-readium copied to clipboard
5-stones
[Bug] Reader view brightness does not match system
I'm having issues with brightness on the page I implemented Readium. The brightness is the same as the system brightness on other pages in the app, but the brightness changes when I navigate to the page with Readium. Also I would like to know if there is any way to control the brightness as in the kotlin-readium?
Note that brightness is not an official preference in the Readium toolkit and is out-of-scope. The test app used to have an example brightness control but I removed it in the last version. It was using Android's screenBrightness property on LayoutParams.
@mickael-menu do you know why the brightness of the toolkit view would not be the same as the system brightness? Or really why there would appear to be a change between the two? Thanks for your help!
Yeah, here you are setting the brightness for the reading activity window. If you leave this activity, it reverts to the system brightness.
https://github.com/5-stones/react-native-readium/blob/5671a7035895fad130669a087e664817311df534/android/src/main/java/com/reactnativereadium/epub/UserSettings.kt#L65-L69
If you used this, maybe this would apply system-wide. But I never tried it: https://developer.android.com/reference/android/provider/Settings.System#SCREEN_BRIGHTNESS
But IMO brightness should be the responsibility of the app and not the Readium toolkit. So I would just remove this brightness preference from your package.
@AmrithVengalath this is fixed in https://github.com/5-stones/react-native-readium/commit/8af916b86a3c42a9abc02a63aa239fa6e8c4e8a5.
this package will simply inherit the brightness of your device.