LinksForIsrael icon indicating copy to clipboard operation
LinksForIsrael copied to clipboard

Horizontal scrolling arrows are not clickable (must long-press to scroll)

Open ohadschn opened this issue 2 years ago • 5 comments

Environment: Windows, Chrome / Edge / Firefox

[EDIT TLDR]: Scroll arrows are not clickable - one must long-press them to scroll (in an amount commensurate with the duration of the press)

  1. [EDIT: THIS SEEMS TO WORK NOW] Using the horizontal mouse scroll wheel does nothing
  2. [EDIT: more precise behavior described in comment below] "dragging" works but the behavior is really weird, it keeps moving by itself (as if we set some constant scrolling velocity).
  3. [EDIT: this was due to some plugin I had (typio form recovery, ignore] Single clicks do nothing and result with the following console error

content.js:7 Uncaught TypeError: Cannot read properties of undefined (reading '0') at Array. (content.js:7:88744) at c.trigger (content.js:7:81786) at HTMLDocument. (content.js:7:81311) (anonymous) @ content.js:7 c.trigger @ content.js:7 (anonymous) @ content.js:7 Show 3 more frames Show less content.js:7 Uncaught TypeError: Cannot read properties of undefined (reading '0') at content.js:7:89004 (anonymous) @ content.js:7 setTimeout (async) (anonymous) @ content.js:7 c.trigger @ content.js:7 (anonymous) @ content.js:7 Show 4 more frames Show less content.js:7 Uncaught TypeError: Cannot read properties of undefined (reading '0') at Array. (content.js:7:89199) at c.trigger (content.js:7:81786) at HTMLDocument. (content.js:7:81253)

ohadschn avatar Nov 20 '23 15:11 ohadschn

For me works as expected Mac.

4tal avatar Nov 20 '23 20:11 4tal

@ohadschn can you please post a short video? I'm not sure I understand the bug

omer-friedman avatar Nov 21 '23 11:11 omer-friedman

@ohadschn can you please post a short video? I'm not sure I understand the bug

@omer-friedman

Let's focus on the simple and most important issue, which doesn't require a video - I click the horizontal scrolling arrows (recently added by Idan) and nothing happens. The console displays the error I pasted in the original post.

image

ohadschn avatar Nov 21 '23 11:11 ohadschn

@ohadschn I added this feature. and I still cant reproduce the bug. it works both in Chrome and Edge (Windows)

https://github.com/4tals/LinksForIsrael/assets/34510256/dc6b3c72-2a70-4068-b31b-df2f07b50548

omer-friedman avatar Nov 21 '23 15:11 omer-friedman

@ohadschn I added this feature. and I still cant reproduce the bug. it works both in Chrome and Edge (Windows)

@omer-friedman

I played with it some more, and it looks like the behavior is something like "scroll in an amount proportionate to the length of the click".

So my usual clicks are really fast and do nothing, but if I keep the mouse button pressed down for a moment, and then release, I the scrolling happens.

Regarding the console error, ignore it, it's due to some plugin I had.

ohadschn avatar Nov 21 '23 16:11 ohadschn