LinksForIsrael icon indicating copy to clipboard operation
LinksForIsrael copied to clipboard

Add createdAt and updatedAt

Open 4tal opened this issue 2 years ago • 9 comments

To track easily when was added and when was updated.

4tal avatar Oct 18 '23 18:10 4tal

why not just git blame and/or git log -G?

ohadschn avatar Oct 18 '23 18:10 ohadschn

You want it as part of the display for the users. uploaded at updated at to give another relevance indicator. Later for verification. every link must be checked at least 1 a month... (for example)

4tal avatar Oct 18 '23 19:10 4tal

Problem would be doing this manually... error prone (e.g. very easy to forget to update updatedAt) I think a proper implementation will generate these properties via the above git commands I mentioned

ohadschn avatar Oct 18 '23 20:10 ohadschn

Yeah can be an automated process.

4tal avatar Oct 19 '23 20:10 4tal

We should have a basic design before to better understand this feature

4tal avatar Oct 19 '23 20:10 4tal

If we'll implement initiative feedback, we can get smarter feedback than created at /updated at. @ohadschn

4tal avatar Nov 10 '23 00:11 4tal

If we'll implement initiative feedback, we can get smarter feedback than created at /updated at. @ohadschn

Initiative feedback like what? "group has many people", "site is full of bugs", things like that? Incorporating something like this would mean somewhat of a full-blown comment / user review system...

ohadschn avatar Nov 10 '23 21:11 ohadschn

@4tal why did you remove the frontend tag? surely, we'd want to display it somehow to the user!

Also, how is this backend? The way I see it we'd simply add it to the auto-PR generation (for both the "create" and "update" scenarios) which is purely DevOps...

As for the initial backfill (namely setting the property for all existing initiatives), we can whip up some script that extracts the addition time from the git history.

ohadschn avatar Nov 28 '23 00:11 ohadschn

@4tal I suggest we start with createdAt only, because that one is easy to add reliably (see associated PR). updatedAt IMO is both less interesting and harder to manage - most of the time we edit initiatives manually and we'll forget for sure (or insert invalid ISO time values, etc)

ohadschn avatar Nov 30 '23 19:11 ohadschn