FModel
FModel copied to clipboard
Incineratez/memoryleak
Bulk exporting properties cause a huge memory leak.
I'm not experienced in C# so I just moved stuff that I think caused it around.
It looks like the actual change was not to display the JSON on save.
While this is a good idea to save resources, the main purpose of FModel is to display information. It has a GUI for a reason and is not meant to be the most efficient/fastest to "bulk do work here". After all, CUE4Parse is separate from FModel.
I know for a fact that some people use these bulk options because all they want is one thing and don't wanna spend time looking into where it is. So they go up enough in the tree, right-click, left-click, and wait.
Against my will, we are slowly moving toward that kind of usage, but why not. However, I think the idea behind this PR can be pushed further. Like not displaying anything after a threshold on the number of packages to deal with, and overall, more context-aware processes. We're still working with a lot of left-over from the auto "do work here" era. A context class will certainly help with readability and maintainability.
This PR won't be merged as is, but I'll keep it open for the time being.