ripme icon indicating copy to clipboard operation
ripme copied to clipboard

DeviantArt: Downloading a DA artist directory only downloads Featured images, not all images

Open Phenrei opened this issue 10 years ago • 5 comments

If you point directly to the full image collection of an artist instead of a subgallery, it only downloads the featured section (sometimes empty, usually not every image) instead of the all images category because the sanitizer filters out the "?catpath=/" part.

I coded a half-fix (it breaks the rip stopping on its own for a reason I can't figure out) that is here: https://github.com/Phenrei/ripme/commit/8a68c79047173a911b4bab523407cec6d0cce5af (ignore the first change).

Short version of it is a quick regex to see if it's base directory or not, and if so keep the ?catpath=/ in all rip URLs. Feel free to clean up, fix my bug, and take all credit.

Phenrei avatar Jun 08 '14 15:06 Phenrei

I realize now it would probably be better to check for the user putting the all images or scraps (?catpath=scraps) parts in the url when sanitizing and then re-add those elements during string creation based on them being present. Just have to move the booleans to the class definition instead of local, but the rest would be similar.

Phenrei avatar Jun 08 '14 16:06 Phenrei

Thanks for pointing this out. I'll take a look at your changes and see what can be pulled/borrowed.

4pr0n avatar Jun 12 '14 07:06 4pr0n

https://github.com/4pr0n/ripme/issues/550

rautamiekka avatar Aug 11 '17 13:08 rautamiekka

@rautamiekka Is this the same issue or just similar? Can we leverage the change posted here?

metaprime avatar Aug 14 '17 08:08 metaprime

^ Similar. The change linked in OP potentially fixes the recursive ripping.

rautamiekka avatar Aug 14 '17 11:08 rautamiekka