ripme icon indicating copy to clipboard operation
ripme copied to clipboard

TwitterRipper: Linter warning: probably incorrect Long.equals(String)

Open metaprime opened this issue 7 years ago • 2 comments

[Java] Unlikely argument type for equals(): String seems to be unrelated to Long

        Long lastMaxID = 0L;
...
            if (tweets.size() == 1 &&
                    lastMaxID.equals(tweets.get(0).getString("id_str"))
                    ) {

metaprime avatar May 09 '17 22:05 metaprime

Its comparing a Long object with string. Merging the fix.

Avinash13iitkgp avatar Jun 05 '17 15:06 Avinash13iitkgp

Looks like https://github.com/4pr0n/ripme/pull/567 is the attempted fix, but I don't understand why the whole file changed. @Avinash13iitkgp can you provide more information about your change?

metaprime avatar Jun 21 '17 16:06 metaprime