ripme icon indicating copy to clipboard operation
ripme copied to clipboard

Published 20 hours ago • verified publisher icon 4pr0n

Flickr

Open bobobo1618 opened this issue 9 years ago • 2 comments

Adds a Flickr API based ripper. Depends on https://github.com/4pr0n/ripme/pull/286 at the moment.

I know all the PRs I'm sending will need a lot of cleaning.

bobobo1618 avatar Jan 02 '16 02:01 bobobo1618

Nice work..

I also like the idea of different storage back-ends.

But right now this PR has 4 commits and 90 files changed. Maybe that is a bit much. I think it would be easier to split it up in different parts. And, for example, start just with one or two rippers, test and merge, and then adapt all the other different rippers?

Hrxn avatar Jan 03 '16 07:01 Hrxn

@Hrxn that'd be good but since I've changed the constructor and AbstractRipper, which all other rippers depend on, I don't think it's feasible to break it up like that.

Flickr definitely shouldn't be in here though, I'm not sure how that happened...

bobobo1618 avatar Jan 03 '16 08:01 bobobo1618