ripme
ripme copied to clipboard
4pr0n
Add switchable storage backends.
Followup to https://github.com/4pr0n/ripme/issues/285.
This is my (working but horrendously messy) code that adds Google Cloud Storage and Amazon S3 as storage backends for ripme.
This is really ambitious!
I checked out the code and could fix some things (like the new RedditRipper changes), but it looks like it broke the VideoRipper -- rips are no longer saved to "videos" subdirectory. I can't find a way to fix this.
Do they get saved anywhere else? Admittedly I don't have any videos to rip. I messed around a lot with the directory naming and stuff (AbstractRipper) so I suspect they might be missing the prefix.
Videos are saved to the root folder (where ripme.jar is, one dir above rips).
I tried inserting videos into the path (in VideoRipper.java) but it tried to save files to {full_path_to_ripme.jar} / {full_path_to_videos_dir}
Here's a SFW video you can test the ripper with: https://vid.me/4ahQ
Ah, I remember now.
The issue was that I just didn't port the DownloadVideoThread over to the new infrastructure. It seems to work now but looking through it it's likely I've left a few little bugs due to my lack of understanding the code.
I'm interested in this but it's a significant change so I'm not going to prioritize this for the moment. In the meantime, any work you could put in to test it and clean it up would be appreciated!
@bobobo1618 are you still interested in getting this PR merged? If so make it in https://github.com/RipMeApp/ripme as development has moved there
@cyian-1756 Ultimately I think we need to decide whether we want to take this, and if so, we need to adopt the code and fix it up ourselves (port it over to ripmeapp/ripme)