OpenMLDB icon indicating copy to clipboard operation
OpenMLDB copied to clipboard

fix: make clients use always send auth info

Open oh2024 opened this issue 1 year ago • 3 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix

  • What is the current behavior? (You can also link to an open issue here) Clients need a flag to enable BRPC authentication and send tokens. This causes a problem for the java sdk which cannot set GFLAGS to enable auth

  • What is the new behavior (if this is a feature change)? Clients always send brpc auth tokens. Servers validate tokens or not based on the skip grant tables flag

oh2024 avatar Apr 28 '24 10:04 oh2024

SDK Test Report

102 files  102 suites   2m 13s :stopwatch: 357 tests 343 :white_check_mark: 14 :zzz: 0 :x: 483 runs  469 :white_check_mark: 14 :zzz: 0 :x:

Results for commit b3495a3f.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 28 '24 11:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.16%. Comparing base (d9bb344) to head (b3495a3). Report is 1 commits behind head on main.

Files Patch % Lines
src/auth/brpc_authenticator.cc 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3906      +/-   ##
============================================
+ Coverage     74.98%   75.16%   +0.18%     
  Complexity      658      658              
============================================
  Files           751      751              
  Lines        135067   135059       -8     
  Branches       1501     1979     +478     
============================================
+ Hits         101276   101517     +241     
+ Misses        33503    33254     -249     
  Partials        288      288              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 28 '24 12:04 codecov[bot]

Linux Test Report

    59 files     252 suites   1h 43m 31s :stopwatch: 13 509 tests 13 502 :white_check_mark: 7 :zzz: 0 :x: 19 181 runs  19 174 :white_check_mark: 7 :zzz: 0 :x:

Results for commit b3495a3f.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 29 '24 15:04 github-actions[bot]