OpenMLDB icon indicating copy to clipboard operation
OpenMLDB copied to clipboard

fix: BufferOverflowException when import data fix #3728

Open ljwh opened this issue 1 year ago • 3 comments

close #3728

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) bug fix

  • What is the current behavior? (You can also link to an open issue here) see #3728

ljwh avatar Jan 26 '24 03:01 ljwh

it's better to add the test case in https://github.com/4paradigm/OpenMLDB/blob/main/java/openmldb-common/src/test/java/com/_4paradigm/openmldb/common/RowCodecTest.java

dl239 avatar Jan 29 '24 02:01 dl239

it's better to add the test case in https://github.com/4paradigm/OpenMLDB/blob/main/java/openmldb-common/src/test/java/com/_4paradigm/openmldb/common/RowCodecTest.java

done

dl239 avatar Jan 30 '24 10:01 dl239

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b2f85fb) 40.18% compared to head (0b66af0) 78.20%. Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3729       +/-   ##
=============================================
+ Coverage     40.18%   78.20%   +38.02%     
=============================================
  Files           193      539      +346     
  Lines         11384   120229   +108845     
  Branches       1366        0     -1366     
=============================================
+ Hits           4575    94029    +89454     
- Misses         6510    26200    +19690     
+ Partials        299        0      -299     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 11:01 codecov[bot]