OpenMLDB icon indicating copy to clipboard operation
OpenMLDB copied to clipboard

feat: add disktable status

Open Leowner opened this issue 2 years ago • 5 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Add SchedGC, GetRecordPkCnt and GetRecordIdxCnt in disktable

Leowner avatar May 10 '22 14:05 Leowner

SDK Test Report

0 tests   0 :heavy_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 56bdd39b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '22 14:05 github-actions[bot]

Linux Test Report

0 tests   0 :heavy_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 56bdd39b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '22 15:05 github-actions[bot]

Codecov Report

Base: 75.60% // Head: 75.86% // Increases project coverage by +0.25% :tada:

Coverage data is based on head (cafba7a) compared to base (26ba54c). Patch coverage: 98.32% of modified lines in pull request are covered.

:exclamation: Current head cafba7a differs from pull request most recent head 56bdd39. Consider uploading reports for the commit 56bdd39 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1788      +/-   ##
============================================
+ Coverage     75.60%   75.86%   +0.25%     
+ Complexity      392      354      -38     
============================================
  Files           644      619      -25     
  Lines        121346   117998    -3348     
  Branches       1060     1039      -21     
============================================
- Hits          91748    89523    -2225     
+ Misses        29361    28264    -1097     
+ Partials        237      211      -26     
Impacted Files Coverage Δ
src/storage/disk_table.h 72.56% <91.07%> (-15.52%) :arrow_down:
src/storage/disk_table.cc 87.47% <97.63%> (+6.03%) :arrow_up:
src/storage/disk_table_test.cc 99.78% <100.00%> (+<0.01%) :arrow_up:
src/storage/table_test.cc 99.76% <100.00%> (+0.46%) :arrow_up:
...java/com/_4paradigm/openmldb/sdk/SqlException.java 0.00% <0.00%> (-100.00%) :arrow_down:
src/storage/table.cc 70.73% <0.00%> (-16.27%) :arrow_down:
.../openmldb/batch/nodes/GroupByAggregationPlan.scala 73.80% <0.00%> (-11.91%) :arrow_down:
...n/java/com/_4paradigm/openmldb/jdbc/SQLDriver.java 50.72% <0.00%> (-11.19%) :arrow_down:
hybridse/include/sdk/base.h 19.23% <0.00%> (-10.40%) :arrow_down:
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 13 '22 16:05 codecov[bot]

check if there is ut to check: after gc, the data is actually deleted

zhanghaohit avatar Jul 28 '22 03:07 zhanghaohit

@Leowner could you update the code to resolve the conflict?

tobegit3hub avatar Mar 01 '24 08:03 tobegit3hub