prometheus-api-client-python icon indicating copy to clipboard operation
prometheus-api-client-python copied to clipboard

Published 20 hours ago • verified publisher icon 4n4nd

Fix [FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.]

Open psujit775 opened this issue 2 years ago • 2 comments

Fix [FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.]

Upstream issue: https://github.com/pandas-dev/pandas/issues/35407

psujit775 avatar Aug 31 '22 14:08 psujit775

@psujit775 could you please check why the tests are failing? Maybe the pandas version needs to be updated

4n4nd avatar Aug 31 '22 15:08 4n4nd

@4n4nd updated Pipfile and requirements.txt to pandas min version >=1.4.0.

Deprecations reference: https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append

psujit775 avatar Aug 31 '22 19:08 psujit775

@psujit775 could you also update the piplock?

4n4nd avatar Oct 20 '22 16:10 4n4nd

@4n4nd updated the Pipfile.lock file.

psujit775 avatar Oct 20 '22 16:10 psujit775

Thanks!

4n4nd avatar Oct 20 '22 16:10 4n4nd

Thank you Anand for merging it.

I know it's just a little change but I'm so happy.

Thanks again,

On Thu, Oct 20, 2022 at 10:24 PM Anand Sanmukhani @.***> wrote:

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/4n4nd/prometheus-api-client-python/pull/247#issuecomment-1285869822, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMC2IGT7WPM7NUBPQUCGG6DWEF2LDANCNFSM6AAAAAAQBNTRAQ . You are receiving this because you were mentioned.Message ID: @.***>

psujit775 avatar Oct 20 '22 17:10 psujit775

Thank you for working on it!

4n4nd avatar Oct 20 '22 17:10 4n4nd