Ivan Akimov
Ivan Akimov
@ChickenProp Sorry for the late response and I agree - the tests should be the same across implementations. We're fixing that as we're moving to the new algorithm. Closing since...
Most libs are pre-production too. That's fine, because we are testing here not just the implementation, but the algorithm too. Ideally, we'd give this implementation several months before we bump...
@robhanlon22 Thanks for the PR. Two questions for you: 1. Shouldn't newly exported constants be screaming snake case since that's typically the convention for hardcoded values? 2. I do like...
@robhanlon22 Cool, thank you. Regarding naming convention, I always thought this approach was reasonable for JS: https://stackoverflow.com/a/49537197
https://github.com/cdnjs/packages/issues/1899
Hey @iCyberon, that'd be great! Just sent you a maintainer invite to the repo, so feel free to push as you see fit. I think quite a few people would...
@JitYc Help would be appreciated, yes. @iCyberon Looks like you should have access to this repo, do you have an approximate ETA on when you might give this a shot?
Pushed a work-in-progress, works ok in development env. Still missing tests + better error handling. Going to close this general issue, please open new ones as you see specific problems...
@kevinxmorales Do we have blockers on this one?
Sounds like it's working? Closing. Re-open if necessary.