lldb-write icon indicating copy to clipboard operation
lldb-write copied to clipboard

1. Allow absolute paths; 2. File not closed; 3. ANSI escape sequences not stripped

Open paul-j-lucas opened this issue 4 years ago • 1 comments

There are a few problems with this code:

  1. It should allow absolute paths. Specifically, it should not prepend ./ to the path. It should simply leave the path alone.
  2. The file isn't closed.
  3. When you send the output to a file, LLDB includes what it would have sent to the terminal verbatim. For a color terminal, this includes ANSI escape sequences. These should be stripped from the output.

I would have created a branch and submitted a pull request, but don't have write-permission to the repo; so here's a patch. patch.txt

paul-j-lucas avatar Apr 29 '21 15:04 paul-j-lucas

Hi!

Thanks very much for taking the time to write this feedback & send a patch

I agree with all these points and have merged fixes for the first two. I will merge the third soon.

Cheers! (and sorry for the late reply)

4iar avatar Aug 10 '21 06:08 4iar