GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Update electron to v32

Open arthuro555 opened this issue 8 months ago • 11 comments

Closes #6530

This update is long due, this update shouldn't require deep changes to GDevelop, and only needed minor updates to a few dependencies. I picked v32 instead of latest as there are changes to native modules in v33 that might have more unpredictable impacts on desktop builds.

Tested the IDE, tested making and running a manual build of a test project with the steamworks extension. Everything seems to work.

arthuro555 avatar Apr 01 '25 10:04 arthuro555

Thanks for doing this! I'll launch an experimental build to see if we can test built versions on multiple systems.

4ian avatar Apr 03 '25 16:04 4ian

Hmm.... The build errors are because the ubuntu version of the CI is too old and doesn't bundle gcc with c++ 20 support :/ I had not updated to the latest version of electron precisely to avoid these troubles, but I guess electron-builder already adopted the requirement too :sweat:

That means that the one-click packaging service probably also will need to be updated and tested for c++ 20 support before shipping this update!

arthuro555 avatar Apr 07 '25 12:04 arthuro555

(We probably should wait before updating electron more still though, as there are other breaking changes with worrying implications in v33)

arthuro555 avatar Apr 07 '25 12:04 arthuro555

oh my god what is UP with these CI

arthuro555 avatar Oct 21 '25 18:10 arthuro555

We can ignore semaphore and Travis. I'll launch experimental builds for this branch

4ian avatar Oct 21 '25 19:10 4ian

Started 👍 Let's see

4ian avatar Oct 21 '25 19:10 4ian

I added in a little extra fix - if you used the "Hide a window" electron action, requestAnimationFrame would stop firing, making it impossible to get the window to come back up - I set an option on previews and build BrowserWindows to disable this behavior.

arthuro555 avatar Oct 21 '25 19:10 arthuro555

Hmm, it looks like electron-builder slightly changed the code signing configuration

arthuro555 avatar Oct 21 '25 20:10 arthuro555

Just tested this on Windows and macOS, so far I don't see any issue! :) A web export seems to work, no issues found when playing a few projects, Piskel seem to work fine.

You said you could run a manual build of a game with Steamworks, no issue there too? I believe that's the main "native module" that we rely on. Anything else on your mind that would be worth checking?

4ian avatar Oct 25 '25 15:10 4ian

image

hm, i tired doing a one click build with the nightly build and it looks like it didnt work... the build service will need to be adapted before merging

arthuro555 avatar Oct 26 '25 09:10 arthuro555

Ah right obviously the electron version of games is also updated. Totally overlooked this. I'll take a look!

4ian avatar Oct 26 '25 16:10 4ian