GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Update pickAllObjects to use gdja.copyArray

Open arthuro555 opened this issue 9 months ago • 2 comments

Replace the push hack with gdjs.copyArray. Misusing push like this can cause issues when a large amount of objects are used.

(Untested, quick edit made from my phone)

arthuro555 avatar Mar 03 '25 02:03 arthuro555

To get a bit more context, did this cause an issue? If not, what type of issue can this cause?

ClementPasteau avatar Mar 07 '25 14:03 ClementPasteau

If there are too many objects it can crash the game for exceeding the maximum call stack size, it caused a crash in HelperWesley's game

arthuro555 avatar Mar 07 '25 14:03 arthuro555

Better late than never, I think this is perfectly valid :)

4ian avatar Jul 03 '25 21:07 4ian