GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Configure Offset banner params.

Open devgiordane opened this issue 1 year ago • 1 comments

set offset to 0 for just overlapping the banner on top of the content.

devgiordane avatar Aug 28 '24 02:08 devgiordane

I think the current option of just pushing the screen down is a solution that makes the game presentation very ugly, I think that giving the option to deal with the overlap and then leaving that area of ​​your game free, makes more sense compared to how ads are shown in other games. I removed the reference here from the documentation

https://admob-plus.github.io/docs/cordova/ads/banner

devgiordane avatar Aug 28 '24 02:08 devgiordane

Hi! Thanks for your contribution.

I think we should even go further and decide that banners will always overlap the game. I.e: always set the offset to 0. This means that the game area is not moved - which is usually ugly and can lead to weird behavior. Instead, it's up to the game creator to just adjust their game design to account for the banner presence.

If that's what you also think, we can probably always set offset: 0. We'll re-introduce an action to change this if needed in the future.

4ian avatar Aug 29 '24 16:08 4ian

I think it's great, that was my initial idea, since the banner is something that is placed consciously, dealing with it on the screen seems correct, I made the configuration just because I thought about flexibility. But from my point of view, banners are always over the game, so having the "offset" should be a good default setting.

devgiordane avatar Aug 29 '24 21:08 devgiordane